Override lemmy server URL when 'VITE__TEST_MODE' is set #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change `urlSelector` and `updateConnectedInstance` to always use `getDefaultServer` as instance. * In e2e.yml, include this in the build project step env.
|
Missed an import. Added in the second commit. |
sharunkumar
reviewed
Aug 24, 2024
| export const urlSelector = (state: RootState) => | ||
| instanceSelector(state) ?? state.auth.connectedInstance; | ||
| export const urlSelector = (state: RootState) => { | ||
| if (import.meta.env.VITE__TEST_MODE) return state.auth.connectedInstance; |
There was a problem hiding this comment.
curious: shouldn't this be implemented by mocking when running the tests? 🤔
There was a problem hiding this comment.
That would be a nice improvement
There was a problem hiding this comment.
Sorry for taking this long to respond.
Not entirely clear on what we would want to mock here, @sharunkumar. Could you please expand on it? Feel free to chime in, @aeharding.
aeharding
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the user logs in,
state.auth.currentInstancechanges from<hostname>:<PORT>to<hostname>[1]. SettingVITE__TEST_MODE=1will override this behaviour with a couple of small changes and no side-effects. Using this var name because similar overrides might be needed elsewhere in the future and this should cover most (or all) of them.Also updated the build step in e2e action.
[1]: Lemmy sets the
issclaim to hostname when creating JWTs.authSlice.addJwtupdatesstate.auth.currentInstancewith the value of this claim.