Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped modlog with moderation reason #1402

Merged
merged 13 commits into from
Apr 19, 2024

Conversation

0xCmdrKeen
Copy link
Contributor

By request, I rebased my old branch for #1046 to hopefully work with the recent code changes.

Had to restore a couple of functions that were removed or changed (helpers/array.ts#notEmpty() and useIsAdmin() with optional argument). Only tested briefly but seems to work fine.

@0xCmdrKeen 0xCmdrKeen requested a review from aeharding as a code owner April 12, 2024 12:05
Copy link
Owner

@aeharding aeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR, I'll review it in detail soon!

src/helpers/array.ts Outdated Show resolved Hide resolved
src/features/moderation/logs/ModlogItem.tsx Outdated Show resolved Hide resolved
Copy link
Owner

@aeharding aeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, this is a lot nicer experience. Just a few questions and then can get this in!

src/features/moderation/useIsAdmin.tsx Show resolved Hide resolved
src/helpers/useAppNavigation.ts Outdated Show resolved Hide resolved
src/features/moderation/logs/ModlogItem.tsx Show resolved Hide resolved
@aeharding aeharding enabled auto-merge (squash) April 18, 2024 23:59
Copy link
Owner

@aeharding aeharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just failing CI

@aeharding aeharding merged commit c320354 into aeharding:main Apr 19, 2024
2 of 3 checks passed
@aeharding
Copy link
Owner

DOH, I don't know why Github didn't wait for successful CI before merging :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants