Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change runtime docker from node to nginx #1379

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Change runtime docker from node to nginx #1379

merged 3 commits into from
Mar 30, 2024

Conversation

aeharding
Copy link
Owner

Since upgrading to require Lemmy 0.19, Voyager no longer requires a backend.

So to simplify the runtime, I've switched out Node to nginx. There is a small script generate_config.sh that generates the server JSON list from CUSTOM_LEMMY_SERVERS on startup.

@aeharding
Copy link
Owner Author

Requesting the review of those that have worked on the Voyager docker image- @sharunkumar, @mbentley, @jonesetc, @Crazybus (sorry for the spam if you are not interested!)

@sharunkumar
Copy link
Contributor

Looks like the port has been changed to 80 as default, might break existing configurations that forward to port 5314

Readme can be updated to show this change: docker run --init --rm -it -p 5314:80 voyager.

I built and ran the container locally with the above command and seems to be working fine

@aeharding
Copy link
Owner Author

@sharunkumar Thanks, I did a change that should preserve the old port!

@aeharding aeharding merged commit ed78eef into main Mar 30, 2024
2 checks passed
@aeharding aeharding deleted the cleanup-docker branch March 30, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants