Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display domain on compact posts #1348

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

bishtawi
Copy link
Contributor

Addresses #1331

I love your app! Thought I would give it a go and add this feature since it seemed straight forward.

Screenshot:
Screenshot from 2024-03-20 00-32-41

CSS can probably use some work. Not sure how much effort it is, but including the site's favicon to the left of the domain name could be a nice touch.

@bishtawi bishtawi force-pushed the compact-post-hostname branch 2 times, most recently from c122420 to 84e7cfa Compare March 20, 2024 16:14
@aeharding
Copy link
Owner

Hi, thanks for the PR!

We probably should add an option to configure this in Settings since I don't think everyone will want this in their feed. Can you look at that? There is already a section for compact appearance settings :)

@bishtawi
Copy link
Contributor Author

Personally I am of the belief that its good security practice to have the domain name always visible so that the user is aware of where they are about to browse to when they click a link; I dont think there should be an option to disable it. But that's just my opinion, I implemented it as you requested. If a user wants to click on random links without knowing where they might end up, that's their prerogative 🤷

@aeharding aeharding force-pushed the compact-post-hostname branch from e7a003e to 03cd3bd Compare March 22, 2024 20:30
@aeharding
Copy link
Owner

@bishtawi that's actually a really good point, and since we don't allow disabling the URL display anywhere else in the app its probably best to be consistent for now and force the URL to always show. I'll revert that commit. Thanks for pointing that out.

BTW nice work on extracting out the parseUrlForDisplay function! I just tried out the PR in more detail made some tweaks to the CSS/display of URL:

  1. URL now displays in parenthesis
  2. URL has max length, so long URLs (or large font sizes) don't break the layout
  3. URL for images are hidden
  4. URL now displays in title of post

Let me know what you think!

@bishtawi
Copy link
Contributor Author

This looks good to me! Thanks for fixing the CSS. I hate dealing with CSS 😅

@aeharding aeharding merged commit 7765efc into aeharding:main Mar 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants