Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: "Start New Game" Wizard with scalable intro image #2674

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ivan-mogilko
Copy link
Contributor

@ivan-mogilko ivan-mogilko commented Feb 1, 2025

Fix #2622

  1. Remake the WizardDialog's title screen into the separate WizardIntroPage control class.
  2. Adjust "start new game" pages to scale to the dialog's size, where makes sense. Dialog is relying on each page's "MinimalSize" property when calculating necessary window size.
  3. Make "Templates" page high enough to fit at least 2 rows of template icons.
  4. Replaced the old intro image with a combination of 2 images found attached in Editor: adjust the intro page in the New Game Wizard, make height higher #2622: background pic that is scaled to fit the page's height, and a cup pic of a fixed size.

I was not exactly sure how to position the cup on the background, so just placed it how seemed okay. But this is trivial to modify.

Example of looks:
new-newgamewizard

Here's how it looks for a smaller wizard:
new-newgamewizard-small

TODO:
1. I do not like the fact that the image is duplicated as a resource encoded in base64. I'd rather have it embedded as a png and loaded, since we have it in repo anyway.
2. Add new pic author to credits.

@ivan-mogilko ivan-mogilko added what: editor related to the game editor context: ui/ux labels Feb 1, 2025
@ivan-mogilko ivan-mogilko force-pushed the 362--newgamewizardscaling branch from 756ec2d to 4702933 Compare February 2, 2025 06:50
@ericoporto
Copy link
Member

ericoporto commented Feb 2, 2025

Tested and this appears to work.

I discovered a bug while testing this, in the Editor, if you use the Editor in a different monitor than your main one, and then exit the editor, if you then disconnect this extra monitor, and then load the Editor, it loads positioned in the position it should be in thie previously connected monitor monitor (except that monitor is disconnected), some modal dialogs (like the beta) shows up in the center of the monitor that you do have and others (like the new game wizard) shows up in a corner of the screen. The main ags editor though can't be clicked anymore, because it is in the position it would be if the extra monitor was connected - so it is off-screen. I think this issue with displays may be related to how we store the position of either windows or layouts and use it to reload the editor, without checking for actual desktop boundaries. I think this is related to e9a9e0b .

@ivan-mogilko
Copy link
Contributor Author

ivan-mogilko commented Feb 2, 2025

Please, open a new bug issue for this problem.

I think this issue with displays may be related to how we store the position of either windows or layouts and use it to reload the editor, without checking for actual desktop boundaries. I think this is related to e9a9e0b .

"WindowsConfig" does not save main editor window, it has only few handpicked dialogs, and I thought that the positions should be relative to the main form (although that has to be double checked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context: ui/ux what: editor related to the game editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: adjust the intro page in the New Game Wizard, make height higher
2 participants