Skip to content

Commit

Permalink
Remove no longer applicable TODO
Browse files Browse the repository at this point in the history
After the version PR, this TODO message no longer applies.

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
  • Loading branch information
estesp committed Feb 22, 2017
1 parent a463ba3 commit 81c6e43
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ SNAPSHOT_PACKAGES=$(shell go list ./snapshot/...)
COMMANDS=ctr containerd containerd-shim protoc-gen-gogoctrd dist ctrd-protobuild
BINARIES=$(addprefix bin/,$(COMMANDS))

# TODO(stevvooe): This will set version from git tag, but overrides major,
# minor, patch in the actual file. We'll have to resolve this before release
# time.
GO_LDFLAGS=-ldflags "-X $(PKG).Version=$(VERSION) -X $(PKG).Package=$(PKG)"

# Flags passed to `go test`
Expand Down

0 comments on commit 81c6e43

Please sign in to comment.