Dialog API buff-up. #325
Merged
Dialog API buff-up. #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l and all take a jQuery selector or jQuery object.
… already been closed.
|
Test failure seems to be a travis error. It can't install phantomjs for ember-release, but default, beta, and canary all pass fine. |
|
|
||
| constants: service(), | ||
|
|
||
| didInsertElement() { | ||
| if (this.get('escapeToClose')) { | ||
| let parent = this.get('parentElementSelector'); | ||
| $(parent).on(`keydown.${this.elementId}`, (e) => { |
There was a problem hiding this comment.
Why this change?
+this.get('defaultedParent')
-this.get('parentElementSelector')defaultedParent is the new parentElementSelector?
There was a problem hiding this comment.
+1, parentElement || parentElementSelector is a very clear descriptor.
There was a problem hiding this comment.
I'm not complaining about the names. Just trying to understand.
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent,origin,openFrom,closeToare all optional and all take a jQuery selector or jQuery object.I found the original API inconsistent and inconvenient in actual use. This PR normalized the API and cleans up some old code remnants.
Note that
parentis not an id, but a jQuery selector or object. An id is created, if needed, for{{ember-wormhole}}.