Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fab-speed-dial: new component implemenation #215

Closed
wants to merge 13 commits into from
Closed

fab-speed-dial: new component implemenation #215

wants to merge 13 commits into from

Conversation

christiananese
Copy link

Demo: http://chrisitananese.github.io/ember-paper/#/fab-speed-dial

  • angular material scss only
  • added fab option to paper-button
  • fling animation
  • scale animation

@miguelcobain
Copy link
Collaborator

  • fix typo "Absolut" to "Absolute"
  • add changelog entry for next patch version

Looks great! Need to review a bit more in depth.

@christiananese
Copy link
Author

Should be fine now.

@jamesdixon
Copy link

looks great @chrisitananese ! Excited to give this a shot once it's merged.

@jamesdixon
Copy link

@chrisitananese any chance on getting this merged soon?

@christiananese
Copy link
Author

No idea @jamesdixon ,I think @miguelcobain wanted to review this before merging. Since my last commit, travis-ci seems to fail for ember-beta, I'll fix that these days.

@jamesdixon
Copy link

loud and clear. thanks @chrisitananese

@xomaczar
Copy link
Contributor

xomaczar commented Jan 8, 2016

@miguelcobain what's the status of this PR, can it be merged?

@miguelcobain
Copy link
Collaborator

@chrisitananese Sorry for asking you this.

Right now our main goal is to hit 1.0, since angular material hit 1.0 as well. Their components should be more stable from now on.
Could you please make this conform #249.

That's like our big goal for now. I wouldn't want to merge this pre-v1 to have more work later on to put on par with v1.

Sorry again.
You did a great job here. Probably this component didn't event change much.

On the v1 branch we're already automatically importing sass styles from angular material. No more copy pasting. I really wanted to push that vision into others. It will make ember-paper a much bigger, solid thing.

@DanChadwick DanChadwick changed the title Feature/paper fab speed dial fab-speed-dial: new component implemenation Apr 20, 2016
@jamesdixon
Copy link

@chrisitananese I'm working on getting this 1.x compatible and had a quick question for you:

The md-css-variables line here is pointing to an empty div in the component, which is then throwing an error when it tries to parse the value of that div into an integer. Do you have any idea what's supposed to go here?

@miguelcobain
Copy link
Collaborator

Closing this as we already have the speed dial implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants