Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove engines from addon package.json #739

Merged
merged 1 commit into from
Jun 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: yarn

- name: Install Dependencies
Expand All @@ -49,7 +49,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: yarn

- name: Install Dependencies
Expand All @@ -72,7 +72,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: yarn

- name: Install Dependencies
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 12.x
node-version: 16.x
cache: yarn

- name: Install Dependencies
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14.x # ember-modifier 4.x requires Node.js 14
node-version: 16.x
cache: yarn

- name: Install Dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-unstable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 16.x
cache: yarn
# This creates an .npmrc that reads the NODE_AUTH_TOKEN environment variable
registry-url: 'https://registry.npmjs.org'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ You can find interactive documentation [here](http://adopted-ember-addons.github
* Ember 4 compatibility requires ember-keyboard 7.x or higher
* For Ember 3.8 to 3.28, you can use ember-keyboard 6.x (not compatible with Internet Explorer)
* For use with Ember 2.0 up to 3.8 or IE compatibility, use ember-keyboard 5.x.
* Node.js v12 or above (Node v14+ is required for fastboot)
* Node.js v16 or above
* ember-auto-import v2.0.0 or above (this is [v2 addon](https://emberjs.github.io/rfcs/0507-embroider-v2-package-format.html))

## Accessibility Considerations
Expand Down
3 changes: 0 additions & 3 deletions addon/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@
"optional": true
}
},
"engines": {
"node": "12.* || 14.* || >= 16"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
},
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"npm": false
},
"volta": {
"node": "12.22.12",
"node": "16.20.0",
"yarn": "1.22.18"
}
}