Prepare for ember-modifier v4 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows [`ember-modifier` v4 migration guide](https://github.com/ember-modifier/ember-modifier/blob/v3.2.5/MIGRATIONS.md#function-based-modifiers) to remove deprecations added in v3.2.0 and makes addon future ready.
SergeAstapov
commented
Apr 6, 2022
| this.element.addEventListener('focusout', this.onFocusOut, true); | ||
| let modifier; | ||
|
|
||
| if (macroCondition(dependencySatisfies('ember-modifier', '>=3.2.0 || 4.x'))) { |
There was a problem hiding this comment.
This increases code complexity.
However, my thought process is following:
- with such condition, only one version of the modifier class gets into bundle.
- we'll drop older version of ember-modifier support at some point, so one branch will just be deleted
- and most important IMO, it would be messy to use either
modifyordidReceiveArguments/didInstall/willRemovein the same class.
Hence having two separate classes is simpler to handle.
lukemelia
approved these changes
Apr 6, 2022
|
@lukemelia as this was merged, could you please publish v8.1.0? this is enhancement hence I assume it's "minor" rather than "patch" |
|
Done! Thanks, @SergeAstapov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows
ember-modifierv4 migration guide to remove deprecations added in v3.2.0 and makes addon future ready.