Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marked import in format-markdown helper #539

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Fix marked import in format-markdown helper #539

merged 1 commit into from
Nov 27, 2021

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Nov 27, 2021

Noticed in embroider-optimized scenario output:

WARNING in ./helpers/format-markdown.js 14:2-19
export 'default' (imported as 'marked') was not found in 'marked' (possible exports: Lexer, Parser, Renderer, Slugger, TextRenderer, Tokenizer, defaults, getDefaults, lexer, marked, options, parse, parseInline, parser, setOptions, use, walkTokens)
 @ ./templates/deprecations.hbs 1:0-47 3:9-11
 @ ./assets/dummy.js 78:9-49

followed recomendation from https://marked.js.org/#usage

@SergeAstapov SergeAstapov merged commit f7466da into adopted-ember-addons:master Nov 27, 2021
@SergeAstapov SergeAstapov deleted the fix-marked-import branch November 27, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant