Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ember v4 deprecation warnings #461

Closed
wants to merge 4 commits into from
Closed

Fix Ember v4 deprecation warnings #461

wants to merge 4 commits into from

Conversation

charlesfries
Copy link

@charlesfries charlesfries commented Sep 15, 2021

  • Bump ember-cli-fastboot and ember-test-selectors (fix Ember global warnings)
  • Remove ember-keyboard-first-responder-inputs initializer
  • Bump ember-modifier (fix modifier capability warning)

@lukemelia
Copy link
Collaborator

Thanks for working on this @charlesfries. It looks like this change may break Ember 3.8 (based on tests). I'm not opposed to doing that if it is necessary to support 4.0 cleanly, but we would need to do this as part of a breaking change.

@miguelcobain
Copy link

@charlesfries the initializer can be disabled in the config, but the deprecated imports are still there, so it seems like the deprecation is thrown anyway. Since we're doing a v7 anyway, we might as well remove it completely?

ember-modifier is compoatible with ember3.12+: https://github.com/ember-modifier/ember-modifier#compatibility

@lukemelia
Copy link
Collaborator

Closing in favor of @SergeAstapov's PRs linked above.

@lukemelia lukemelia closed this Nov 19, 2021
leoeuclids pushed a commit to leoeuclids/ember-keyboard that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants