Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support binding to "+" key #281

Merged
merged 1 commit into from
Oct 28, 2020
Merged

support binding to "+" key #281

merged 1 commit into from
Oct 28, 2020

Conversation

marcoow
Copy link
Contributor

@marcoow marcoow commented Oct 21, 2020

This adds support for binding to the + via just (if using decorators):

@onKey("+")

I'm not entirely sure how this would work with different language keyboard layouts tbh…

closes #280

@lukemelia lukemelia merged commit cfca708 into adopted-ember-addons:master Oct 28, 2020
@marcoow marcoow deleted the plus-key branch October 28, 2020 07:26
@lukemelia
Copy link
Collaborator

Released as 6.0.2. Thanks @marcoow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot listen to "+" key
2 participants
@marcoow @lukemelia