keep loading until you are out of view #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,5 +73,14 @@ export default Ember.Component.extend({ | |||
| if (this.get('infinityModel.reachedInfinity') && this.get('destroyOnInfinity')) { | |||
| this.destroy(); | |||
| } | |||
| }), | |||
|
|
|||
| infinityModelPushed: Ember.observer('infinityModel.[]', function() { | |||
There was a problem hiding this comment.
We can probably just observe length, right?
There was a problem hiding this comment.
From my understanding, .[] is the same as .length, but I can't find confirmation. Any insight into this?
There was a problem hiding this comment.
Performancewise it's the same, but slightly different in operation: emberjs/ember.js#2016 (comment)
We probably don't want to trigger loadMore if a developer swaps out an item in the array id say
There was a problem hiding this comment.
Thanks for that link. I will change.
|
Updated to remove the component state. |
|
Thanks @kellyselden ! Works for me! |
hhff
added a commit
that referenced
this pull request
Jun 21, 2015
keep loading until you are out of view, closes #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mobile view, the component is out of view on the first load. In desktop view, there is enough space for the component to load more a few times before being out of view. Currently the loader would not do anything because no scroll events occur.
This change will watch for pushes to the model and keep loading data if it is needed. The desktop view will fill up the screen on first page load.