Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @embroider/* packages and add peerDependencies info #630

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Bump @embroider/* packages and add peerDependencies info #630

merged 3 commits into from
Jan 22, 2022

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Jan 18, 2022 •
edited
Loading

Closes # .

Changes proposed in this pull request

PR bumps @embroider/macros packages in dependencies similar to what was done in emberjs/ember-render-modifiers#54 (comment)

Alongside @embroider/macros bump we should add ember-data to peerDependencies for proper resolution.

@SergeAstapov
Copy link
Contributor Author

Seem like build failures caused by some changes in latest patch version of ember-data

@snewcomer wonder if you have some insights/ideas

@SergeAstapov
Copy link
Contributor Author

seem like await settled() is needed after changeset.execute() (which under the hood runs set() onto relationship) when interacting with relationships.
Seem like caused by recent changes in ember-data.

@snewcomer if this looks good for you, do you mind to release new beta with this change?

@SergeAstapov
Copy link
Contributor Author

SergeAstapov commented Jan 18, 2022 •
edited
Loading

embroider-optimized scenario failures caused by ember-data using require() which I assume should be replaced with importSync for embroider compatibility in the ember-data source code

@SergeAstapov SergeAstapov mentioned this pull request Jan 20, 2022
Merged
@SergeAstapov
Copy link
Contributor Author

Created PR to improve embroider story in Ember Data emberjs/data#7849

@SergeAstapov SergeAstapov mentioned this pull request Jan 20, 2022
Merged
@snewcomer snewcomer merged commit e57febd into adopted-ember-addons:master Jan 22, 2022
@SergeAstapov
Copy link
Contributor Author

@snewcomer do you mind to release this as 4.0.0-beta.2?

@SergeAstapov SergeAstapov mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeAstapov @snewcomer