Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nternal: Fix build for Ember v4 #618

Merged
merged 2 commits into from
Oct 26, 2021
Merged

nternal: Fix build for Ember v4 #618

merged 2 commits into from
Oct 26, 2021

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Oct 26, 2021 •
edited
Loading

ember.edition and optional features need to be specified explicitly in order to get build running with Ember v4

@SergeAstapov
Copy link
Contributor Author

this getting weird - build did pass in master just 1 hour ago and now is failing in this PR

@SergeAstapov SergeAstapov changed the title Fix build for Ember v4 nternal: Fix build for Ember v4 Oct 26, 2021
@SergeAstapov
Copy link
Contributor Author

Figured out the root cause:
as this PR set "default-async-observers": true, fixed the test to use await settled() to ensure proper timing of assertions

@snewcomer
Copy link
Collaborator

You are a beast! Thank you.

@snewcomer snewcomer merged commit 1591ec5 into adopted-ember-addons:master Oct 26, 2021
@SergeAstapov SergeAstapov deleted the optional-features branch October 26, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeAstapov @snewcomer