Internal: Upgrade ember-qunit to v5 #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
commented
Oct 26, 2021
| @@ -19,10 +19,6 @@ module('Integration | Component | changeset-form', function (hooks) { | |||
|
|
|||
| assert.true(find('[data-test-submit]').disabled, 'button disabled due to invalid email'); | |||
|
|
|||
| // submit - disabled until fill in proper email | |||
| await click('[data-test-submit]'); | |||
There was a problem hiding this comment.
clicking on disabled button does not have any effect and actually throws with latest @ember/test-helpers
snewcomer
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an internal clean up.
Aligns with the latest Ember CLI addon blueprint and modernizes addon setup (I would guess
ember-qunit@5will become hard requirement at some point).