merge upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go and Java implementations agree with Python 2 and 3 that the sign of x % y should match the divisor (y) not the dividend (x). This change makes the spec match the implementations and the intent. Fixes #148
Expressions like `[][::]` or `[][1::2]` are allowed in Python and in Java Starlark, but not allowed per current spec. Fix that. Copy-paste [Python grammar](https://docs.python.org/3/reference/grammar.html).
* spec: bytes data type This change adds initial specification of the bytes data type following length discussion in #112. It also explains the implementation-dependent encoding of text strings, and the \u and \U escapes. More will follow, but let's get the easy parts out of the way first. Updates #112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.