refactor!: remove onHttpServerMessage logic

adonisjs · Jun 2, 2024 · 1efcdf7 · 1efcdf7
1 parent f312c31
commit 1efcdf7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 92 deletions.
diff --git a/src/dev_server.ts b/src/dev_server.ts
@@ -178,10 +178,6 @@ export class DevServer {
     })
 
     this.#httpServer.on('message', async (message) => {
-      this.#hooks.onHttpServerMessage(hooksArgs, message, {
-        restartServer: () => this.#restartHTTPServer(port),
-      })
-
       /**
        * Handle Hot-Hook messages
        */

diff --git a/tests/dev_server.spec.ts b/tests/dev_server.spec.ts
@@ -127,94 +127,6 @@ test.group('DevServer', () => {
     cleanup(() => devServer.close())
   })
 
-  test('onHttpServerMessage hook should be executed', async ({ assert, fs, cleanup }) => {
-    let receivedMessages: any[] = []
-
-    await fs.createJson('tsconfig.json', {
-      include: ['**/*'],
-      exclude: [],
-    })
-    await fs.create(
-      'bin/server.js',
-      `
-      process.send({ isAdonisJS: true, environment: 'web' });
-      process.send({ type: 'http-server-message', message: 'hello' });
-      `
-    )
-    await fs.create('.env', 'PORT=3334')
-
-    const devServer = new DevServer(fs.baseUrl, {
-      assets: { enabled: false },
-      nodeArgs: [],
-      scriptArgs: [],
-      hooks: {
-        onHttpServerMessage: [
-          async () => ({
-            default: (_, message, __) => {
-              receivedMessages.push(message)
-            },
-          }),
-        ],
-      },
-    })
-
-    await devServer.startAndWatch(ts)
-    cleanup(() => devServer.close())
-
-    await sleep(500)
-
-    assert.deepEqual(receivedMessages, [
-      { isAdonisJS: true, environment: 'web' },
-      { type: 'http-server-message', message: 'hello' },
-    ])
-  })
-
-  test('can restart server from onHttpServerMessage hook', async ({ assert, fs, cleanup }) => {
-    let receivedMessages: any[] = []
-
-    await fs.createJson('tsconfig.json', {
-      include: ['**/*'],
-      exclude: [],
-    })
-    await fs.create(
-      'bin/server.js',
-      `
-      process.send({ isAdonisJS: true, environment: 'web' });
-      process.send({ type: 'restart' });
-      `
-    )
-    await fs.create('.env', 'PORT=3334')
-
-    let wasRestarted = false
-
-    const devServer = new DevServer(fs.baseUrl, {
-      assets: { enabled: false },
-      nodeArgs: [],
-      scriptArgs: [],
-      hooks: {
-        onHttpServerMessage: [
-          async () => ({
-            default: (_, message, { restartServer }) => {
-              receivedMessages.push(message)
-
-              if (message.type === 'restart' && !wasRestarted) {
-                restartServer()
-                wasRestarted = true
-              }
-            },
-          }),
-        ],
-      },
-    })
-
-    await devServer.startAndWatch(ts)
-    cleanup(() => devServer.close())
-
-    await sleep(1000)
-
-    assert.deepEqual(receivedMessages.length, 4)
-  }).timeout(10_000)
-
   test('should restart server if receive hot-hook message', async ({ assert, fs }) => {
     await fs.createJson('tsconfig.json', { include: ['**/*'], exclude: [] })
     await fs.create(