Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix label of plot.vpi() for quantity vir, disable read_vpts test #674

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix label of plot.vpi() for quantity vir, disable read_vpts test #674

merged 3 commits into from
Sep 17, 2024

Conversation

adokter
Copy link
Owner

@adokter adokter commented Sep 16, 2024 •
edited
Loading

  • fixes a mislabeled plot axis for vertically integrated reflectivity (VIR). y-axis label incorrectly mentioned cm^2/km/h, while it should be cm^2/km^2
  • disables a test in test-read_vpts.R related to an issue in read_csv() of package readr

@adokter adokter self-assigned this Sep 16, 2024
@adokter adokter requested a review from fyiguo September 16, 2024 16:49
fyiguo
fyiguo approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@fyiguo fyiguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the label units are now correct

@adokter adokter changed the title fix label of plot.vpi() for quantity vir fix label of plot.vpi() for quantity vir, disable read_vpts test Sep 17, 2024
@adokter adokter merged commit b1067d8 into master Sep 17, 2024
5 checks passed
@adokter adokter deleted the fix_label branch September 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fyiguo fyiguo fyiguo approved these changes

Assignees

@adokter adokter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adokter @fyiguo