Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MINOR) XmpMeta::set_property can now pass XmpValue options #88

Merged
merged 5 commits into from
Oct 20, 2022

Conversation

scouten-adobe
Copy link
Member

Changes in this pull request

XmpMeta::set_property and XmpMeta::set_property_date have both been revised to accept XmpValue<String> or XmpValue<XmpDateTime>, respectively. This allows options to be passed along with the underlying value.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@scouten-adobe scouten-adobe self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #88 (5cf24d5) into main (693417a) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   93.72%   93.83%   +0.11%     
==========================================
  Files           7        7              
  Lines         446      454       +8     
==========================================
+ Hits          418      426       +8     
  Misses         28       28              
Impacted Files Coverage Δ
src/ffi.rs 100.00% <ø> (ø)
src/xmp_date_time.rs 100.00% <100.00%> (ø)
src/xmp_meta.rs 100.00% <100.00%> (ø)
src/xmp_value.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scouten-adobe scouten-adobe merged commit 31d6a0f into main Oct 20, 2022
@scouten-adobe scouten-adobe deleted the set-property+xmp-value branch October 20, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant