Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: update thiserror requirement from 1.0 to 2.0 #247

Merged
merged 6 commits into from
Dec 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/pr_title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ jobs:
exit 0;
fi

if echo "$PR_TITLE" | grep -E '^update: update '; then
echo "Exception / OK: Dependabot update pattern"
exit 0;
fi

echo "Installing commitlint-rs. Please wait 30-40 seconds ..."
cargo install --quiet commitlint-rs
set -e
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ crt_static = []
[dependencies]
chrono = { version = "0.4.24", optional = true }
num_enum = "0.7.0"
thiserror = "1.0"
thiserror = "2.0"

[build-dependencies]
cc = { version = "1.0.101", features = ["parallel"] }
Expand Down
3 changes: 2 additions & 1 deletion deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ allow = [
# "ISC",
"MIT",
# "MPL-2.0",
"Unicode-DFS-2016",
# "Unicode-DFS-2016",
"Unicode-3.0",
# "Zlib",
]
confidence-threshold = 0.9
Expand Down
4 changes: 2 additions & 2 deletions src/xmp_iterator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@ impl<'a> XmpIterator<'a> {
}
}

impl<'a> Drop for XmpIterator<'a> {
impl Drop for XmpIterator<'_> {
fn drop(&mut self) {
unsafe {
ffi::CXmpIteratorDrop(self.i);
}
}
}

impl<'a> Iterator for XmpIterator<'a> {
impl Iterator for XmpIterator<'_> {
type Item = XmpProperty;

fn next(&mut self) -> Option<Self::Item> {
Expand Down
6 changes: 3 additions & 3 deletions src/xmp_meta.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,7 @@ impl fmt::Display for XmpMeta {

struct PropertyDisplayHelper<'a>(pub &'a XmpMeta, pub &'a XmpProperty);

impl<'a> fmt::Debug for PropertyDisplayHelper<'a> {
impl fmt::Debug for PropertyDisplayHelper<'_> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> Result<(), fmt::Error> {
let mut flags: Vec<&'static str> = vec![];
let value = &self.1.value;
Expand Down Expand Up @@ -2213,7 +2213,7 @@ impl<'a> fmt::Debug for PropertyDisplayHelper<'a> {

struct PropertyListHelper<'a>(pub &'a XmpMeta, pub &'a XmpProperty);

impl<'a> fmt::Debug for PropertyListHelper<'a> {
impl fmt::Debug for PropertyListHelper<'_> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> Result<(), fmt::Error> {
let mut dl = f.debug_list();

Expand Down Expand Up @@ -2286,7 +2286,7 @@ pub struct ArrayProperty<'a> {
index: i32,
}

impl<'a> Iterator for ArrayProperty<'a> {
impl Iterator for ArrayProperty<'_> {
type Item = XmpValue<String>;

fn next(&mut self) -> Option<Self::Item> {
Expand Down
Loading