Allow clean build process #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from #212: don't move intermediate build products into versioned paths.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 9 9
Lines 1763 1763
=======================================
Hits 1730 1730
Misses 33 33 ☔ View full report in Codecov by Sentry. |
3 tasks
scouten-adobe
added a commit
that referenced
this pull request
Jul 7, 2024
This reverts commit 5cf92d3. Unfortunately, this complicates the crate publishing process and needs more work than I have time for today.
scouten-adobe
added a commit
that referenced
this pull request
Jul 7, 2024
This reverts commit 5cf92d3. Unfortunately, this complicates the crate publishing process and needs more work than I have time for today.
This was referenced Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from #212: don't move intermediate build products into versioned paths.
Thank you, @uttarayan21, for this patch. I know this was targeted to nix builds, but it makes the build process cleaner on on all platforms. ❤️