Added option for static CRT using /MT flag (thanks @spector-9) #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 9 9
Lines 1599 1599
=======================================
Hits 1566 1566
Misses 33 33 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @spector-9, this looks straightforward. Would you please sign the Adobe contributor license agreement? I'll be happy to merge this once that's completed. Thank you! |
|
@scouten-adobe Done. Thanks. |
|
@spector-9 thanks for this PR. Just released crate version 1.2.1, which includes your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Some libraries might have conflict if they are using /MT and this crate uses /MD flag or vice versa for linking the runtime on Windows. So this just add a simple feature flag to change the runtime to static using /MT if required.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.