-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aarch64 compilation issues #159
Conversation
@jwidauer thank you for drawing this issue to our attention and submitting a fix. I'd like to ensure that we don't lose this change over time. Any chance you could suggest a GitHub Actions enhancement that shows the previous code failing on aarch64 and then shows this PR passing that test? |
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 8 8
Lines 1504 1504
=======================================
Hits 1472 1472
Misses 32 32
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7306c06
to
e09e3f9
Compare
@scouten-adobe Thanks for your quick reply! |
@scouten-adobe Were you able to already have a look at the proposed changes to the CI? What do you think? |
@jwidauer was on vacation late last week; looking at it now. |
I want to see if it detects the aarch64 build failures that were reported.
Confirmed via #160 that the CI changes as proposed do detect the failure and that this version succeeds. Fixing code format in xmp_iterator and then I will merge. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
@scouten-adobe Thanks for the quick responses! Happy this got in! 😄 |
Changes in this pull request
Changes some specific variables from an
i8
to ac_char
, since the functions that use these variables takec_char
s as input.This is specifically an issue when trying to cross compile for aarch64, since
c_char
is defined as au8
for that architecture.Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.