Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aarch64 compilation issues #159

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

jwidauer
Copy link
Contributor

Changes in this pull request

Changes some specific variables from an i8 to a c_char, since the functions that use these variables take c_chars as input.
This is specifically an issue when trying to cross compile for aarch64, since c_char is defined as a u8 for that architecture.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@scouten-adobe
Copy link
Member

@jwidauer thank you for drawing this issue to our attention and submitting a fix. I'd like to ensure that we don't lose this change over time. Any chance you could suggest a GitHub Actions enhancement that shows the previous code failing on aarch64 and then shows this PR passing that test?

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #159 (7a2cdb1) into main (f97147e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files           8        8           
  Lines        1504     1504           
=======================================
  Hits         1472     1472           
  Misses         32       32           
Impacted Files Coverage Δ
src/xmp_iterator.rs 100.00% <100.00%> (ø)
src/xmp_meta.rs 99.80% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jwidauer jwidauer force-pushed the fix-aarch64-compilation branch from 7306c06 to e09e3f9 Compare March 1, 2023 00:49
@jwidauer
Copy link
Contributor Author

jwidauer commented Mar 1, 2023

@scouten-adobe Thanks for your quick reply!
I added another step to the github actions workflow, which uses cross to check the cross compilation to aarch64-unknown-linux-gnu. It should also be pretty easy to extend it to check more architectures as well.
Is this similar to what you had in mind?

@jwidauer
Copy link
Contributor Author

jwidauer commented Mar 6, 2023

@scouten-adobe Were you able to already have a look at the proposed changes to the CI? What do you think?

@scouten-adobe
Copy link
Member

@jwidauer was on vacation late last week; looking at it now.

scouten-adobe added a commit that referenced this pull request Mar 6, 2023
I want to see if it detects the aarch64 build failures that were reported.
@scouten-adobe
Copy link
Member

Confirmed via #160 that the CI changes as proposed do detect the failure and that this version succeeds.

Fixing code format in xmp_iterator and then I will merge. Thank you!

Copy link
Member

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@scouten-adobe scouten-adobe merged commit a8b9763 into adobe:main Mar 7, 2023
@jwidauer
Copy link
Contributor Author

jwidauer commented Mar 7, 2023

@scouten-adobe Thanks for the quick responses! Happy this got in! 😄

@jwidauer jwidauer deleted the fix-aarch64-compilation branch March 7, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants