Don't call exit(1) if unable to initialize C++ XMP Toolkit #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running with this code disabled allowed me to confirm that the Rust toolkit fails as expected (and does not crash) in the unlikely event that the C++ Toolkit doesn't initialize.
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 8 8
Lines 1504 1504
=======================================
Hits 1472 1472
Misses 32 32 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
If C++ XMP Toolkit fails, all calls to Rust XMP Toolkit APIs will fail with
Error::InternalFailure, but the program will no longer self-terminate by callingexit(1). Fixes #100.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.