Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Display for XmpDateTime #103

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Implement Display for XmpDateTime #103

merged 2 commits into from
Oct 22, 2022

Conversation

scouten-adobe
Copy link
Member

Changes in this pull request

This uses the C++ XMP Toolkit's rendering of date/time values to handle numerous edge cases.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

This uses the C++ XMP Toolkit's rendering of date/time values to handle numerous edge cases.
@scouten-adobe scouten-adobe self-assigned this Oct 22, 2022
@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #103 (f0a9001) into main (af51133) will decrease coverage by 0.20%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   95.94%   95.73%   -0.21%     
==========================================
  Files           7        7              
  Lines         690      704      +14     
==========================================
+ Hits          662      674      +12     
- Misses         28       30       +2     
Impacted Files Coverage Δ
src/ffi.rs 100.00% <ø> (ø)
src/xmp_date_time.rs 97.59% <85.71%> (-2.41%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@scouten-adobe scouten-adobe merged commit c697230 into main Oct 22, 2022
@scouten-adobe scouten-adobe deleted the xmp-date-time+fmt branch October 22, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant