fix: make latest storybook-builder-wds work #3409
Conversation
| @@ -155,7 +155,7 @@ | |||
| "fs-extra": "^10.0.0", | |||
| "geckodriver": "4.0.3", | |||
| "gh-pages": "^4.0.0", | |||
| "glob": "^10.3.0", | |||
| "glob": "^8.0.0", | |||
There was a problem hiding this comment.
had to downgrade it, the latest one has CJS and MJS and the glob-promise is using the wrong one, didn't investigate further
| import path from "path"; | ||
| -import sourceMapDefault from "@parcel/source-map"; | ||
| -var { default: SourceMapNode } = sourceMapDefault; | ||
| +import SourceMapNode from "@parcel/source-map"; |
There was a problem hiding this comment.
I raised an issue here chialab/rna#155
|
@Rajdeepc hey, interesting link, thanks! here I'm testing the new builder I'm working on that @Westbrook is interested in |
I am happy to see the official addons support. Its a game changer on the new Storybook and also would love to chat about any plans to onboard webpack5 lazyCompilation support here? Its faster and on demand. In the mean time I will get this setup locally and play around |
|
@Rajdeepc not sure I get you, this new builder is not webpack5 based and generally not related to webpack. It's implementing the preview of the stories using @web/dev-server and new Storybook Builder API (https://storybook.js.org/docs/react/builders/builder-api) and as such it gets certain behavior from |
|
Thanks so much for this @bashmish! If you were OK with signing the CLA, we can merge this into our WIP branch. This is gonna go a long way to getting us onto sb@7, soon!! |
| clearTerminalOnReload: false, | ||
| mimeTypes: { | ||
| '**/*.json': 'js', | ||
| }, |
There was a problem hiding this comment.
I had to disable watch mode here, will investigate together with HMR
for now the server is run in middleware mode as other builder, so watch mode will require a bit different approach
Sure, signed the CLA. Good luck and as always I'm here to help if you run into other issues. I'll work on other features too in the nearest future, stay tuned for updates :) |
Description
Hey, hope this helps with the new builder (https://github.com/bashmish/storybook-builder-wds) and Storybook 7.
Related issue(s)
Motivation and context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.