Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added component-size-maximum-perspective-down token #216

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

lynnhao
Copy link
Contributor

@lynnhao lynnhao commented Dec 18, 2024

Description

Added a component-size-maximum-perspective-down token, which defines that components larger than 96px would appear to scale down more.

Motivation and context

This token is used in larger components that support a down state that scales, like the select box.

Related issue

SDS-14453

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @lynnhao lynnhao self-assigned this Dec 18, 2024
    @lynnhao lynnhao requested a review from a team as a code owner December 18, 2024 22:59
    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.component-size-maximum-perspective-down
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (1) component-size-maximum-perspective-down
    

    TEST COMPLETE

    Copy link
    Contributor

    @PaliwalSparsh PaliwalSparsh left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    @GarthDB GarthDB merged commit ddffc99 into main Dec 19, 2024
    4 checks passed
    @GarthDB GarthDB deleted the lynnhao/SDS-14453-down-max-perspective branch December 19, 2024 18:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants