Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: s2 foundation data set #180

Merged
merged 3 commits into from
Aug 29, 2024
Merged

feat: s2 foundation data set #180

merged 3 commits into from
Aug 29, 2024

Conversation

mrcjhicks
Copy link
Collaborator

@mrcjhicks mrcjhicks commented Aug 27, 2024 •
edited
Loading

Description

Initial S2 Foundation data set synced with spectrum-tokens/snapshot-s2-foundations

Motivation and context

Related issue

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)

    • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)

    • @mrcjhicks mrcjhicks requested a review from a team as a code owner August 27, 2024 18:30
    @mrcjhicks mrcjhicks requested review from GarthDB and karstens August 27, 2024 18:31
    @mrcjhicks
    Copy link
    Collaborator Author

    TESTING foundations

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/foundations/

    TEST COMPLETE

    @karstens karstens mentioned this pull request Aug 28, 2024
    Merged
    @mrcjhicks
    Copy link
    Collaborator Author

    TESTING foundations

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/foundations/

    TEST COMPLETE

    @GarthDB GarthDB merged commit 18752bc into main Aug 29, 2024
    4 checks passed
    @GarthDB GarthDB deleted the cable/s2-foundation-data branch August 29, 2024 15:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @GarthDB GarthDB GarthDB approved these changes

    @karstens karstens karstens approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mrcjhicks @GarthDB @karstens