Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S1 typography, heading tokens update #178

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

larz0
Copy link
Member

@larz0 larz0 commented Aug 27, 2024

Description

Updated these tokens for desktop and mobile:

  • heading-cjk-heavy-font-weight
  • heading-cjk-size-* tokens (except XL, L, and M, which already had the correct values)

Motivation and context

These changes are for CJK typography improvements.

Related issue

SDS-13796

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @larz0 larz0 requested a review from a team as a code owner August 27, 2024 17:51
    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum-non-colors/

    SPECTRUM SYNC SUMMARY

    CHANGED VALUES: (6) heading-cjk-heavy-font-weight, heading-cjk-size-s, heading-cjk-size-xs, heading-cjk-size-xxl, heading-cjk-size-xxs, heading-cjk-size-xxxl impacting 8 tokens
    

    TEST COMPLETE

    @PaliwalSparsh PaliwalSparsh self-requested a review August 28, 2024 13:46
    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum-non-colors/

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum/typography.letter-spacing
    UPDATED METADATA - SPECTRUM UUID: spectrum/typography/desktop.font-size-25
    UPDATED METADATA - SPECTRUM UUID: spectrum/typography/mobile.font-size-25
    

    SPECTRUM SYNC SUMMARY

    NEW TOKENS: (3) letter-spacing, font-size-25/desktop, font-size-25/mobile
    CHANGED VALUES: (7) cjk-letter-spacing, heading-cjk-heavy-font-weight, heading-cjk-size-s, heading-cjk-size-xs, heading-cjk-size-xxl, heading-cjk-size-xxs, heading-cjk-size-xxxl impacting 9 tokens
    CHANGED SCHEMAS: (1) cjk-letter-spacing
    

    TEST COMPLETE

    @karstens karstens merged commit 9e4026e into main Aug 30, 2024
    4 checks passed
    @karstens karstens deleted the larz0/SDS-13796-s1-typography-heading branch August 30, 2024 08:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants