Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in a Stand Panel token #168

Closed
wants to merge 1 commit into from
Closed

Conversation

larz0
Copy link
Member

@larz0 larz0 commented Aug 12, 2024

Description

gripper-drag in dark.json should say gripper-color-drag like what we have in the light theme.

Motivation and context

Fixed typo

Related issue

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @larz0 larz0 requested a review from a team as a code owner August 12, 2024 23:47
    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    WARNING - STUDIO INCLUDES DEPRECATED TOKEN: overlay-opacity/dark [31d5b502-6266-4309-8f8a-3892e6e158da]
    WARNING - STUDIO INCLUDES DEPRECATED TOKEN: overlay-opacity/light [26b9803c-577f-4a29-badd-dfc459e8b73e]

    STUDIO SYNC SUMMARY

    UPDATED METADATA - SPECTRUM UUID: spectrum2/component.Component.standard-panel.gripper-color-drag
    

    SPECTRUM SYNC SUMMARY

    MODIFIED TOKENS: (1) standard-panel-gripper-color-drag
    DEPRECATED TOKENS: (1) standard-panel-gripper-color-drag/dark
    

    TEST COMPLETE

    @@ -269,7 +269,7 @@
    }
    }
    },
    "gripper-drag": {
    "gripper-color-drag": {
    Copy link
    Collaborator

    @karstens karstens Aug 13, 2024

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @larz0 This would be the first color token with the word 'color' in it. Notice: This line in the json file is not the spectrum-tokens name, but the name for the token in figma and the variables. @nabuhasan and @lynnhao might know more...

    Please put the spectrum-tokens name into the nested spectrum-tokens object, e.g. here: https://github.com/adobe/spectrum-tokens-studio-data/pull/168/files#diff-1b6a253c366c334e1436d57bc36dc0e6083a2300ce2c823b8a68c1cca5ef4017L278

    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    In Spectrum Tokens we would want the word color to be in there because it's the property it's changing. I guess we could use fill-color or background-color but color alone is fine. As far as what the name should be in Tokens Studio data, that's up to @nabuhasan and @lynnhao to approve or ask to change.

    @larz0
    Copy link
    Member Author

    larz0 commented Aug 13, 2024

    Closing PR to create a new PR

    @larz0 larz0 closed this Aug 13, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants