-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S2 non-gray-800 colors update #165
Conversation
READING spectrum-tokens:
SPECTRUM SYNC SUMMARY
TEST COMPLETE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed both the PR + the Figma branch. Both look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Note for @GarthDB (?): Tokens Studio currently doesn't have the Wireframe theme so we might have to update
wireframe-blue: 5074c5
manually. It's used as the 800 color for all non-gray colors in the “wireframe” theme.Updated S2 non-gray-800 tokens in dark theme, and all aliases impacted to refer to the updated tokens:
silver-800
magenta-800
red-800
orange-800
brown-800
yellow-800
chartreuse-800
celery-800
green-800
seafoam-800
turquoise-800
cyan-800
blue-800
indigo-800
purple-800
fuchsia-800
pink-800
cinnamon-800
accent-background-color-default
accent-background-color-hover
accent-background-color-down
accent-background-color-key-focus
informative-background-color-default
informative-background-color-hover
informative-background-color-down
informative-background-color-key-focus
blue-background-color-default
negative-background-color-default
negative-background-color-hover
negative-background-color-down
negative-background-color-key-focus
red-background-color-default
positive-background-color-default
positive-background-color-hover
positive-background-color-down
positive-background-color-key-focus
green-background-color-default
seafoam-background-color-default
cyan-background-color-default
indigo-background-color-default
purple-background-color-default
fuchsia-background-color-default
magenta-background-color-default
pink-background-color-default
turquoise-background-color-default
brown-background-color-default
cinnamon-background-color-default
silver-background-color-default
Motivation and context
These updates to colors ensure we have a color stop that is 4.5:1 with white and 3:1 with gray-100. These color updates will fix accessibility issues for selected, accent variants in some components, like action button and tag.
Types of changes
Checklist: