Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2 non-gray-800 colors update #165

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

larz0
Copy link
Member

@larz0 larz0 commented Aug 12, 2024

Note for @GarthDB (?): Tokens Studio currently doesn't have the Wireframe theme so we might have to update wireframe-blue: 5074c5 manually. It's used as the 800 color for all non-gray colors in the “wireframe” theme.

Updated S2 non-gray-800 tokens in dark theme, and all aliases impacted to refer to the updated tokens:

  • silver-800

  • magenta-800

  • red-800

  • orange-800

  • brown-800

  • yellow-800

  • chartreuse-800

  • celery-800

  • green-800

  • seafoam-800

  • turquoise-800

  • cyan-800

  • blue-800

  • indigo-800

  • purple-800

  • fuchsia-800

  • pink-800

  • cinnamon-800

  • accent-background-color-default

  • accent-background-color-hover

  • accent-background-color-down

  • accent-background-color-key-focus

  • informative-background-color-default

  • informative-background-color-hover

  • informative-background-color-down

  • informative-background-color-key-focus

  • blue-background-color-default

  • negative-background-color-default

  • negative-background-color-hover

  • negative-background-color-down

  • negative-background-color-key-focus

  • red-background-color-default

  • positive-background-color-default

  • positive-background-color-hover

  • positive-background-color-down

  • positive-background-color-key-focus

  • green-background-color-default

  • seafoam-background-color-default

  • cyan-background-color-default

  • indigo-background-color-default

  • purple-background-color-default

  • fuchsia-background-color-default

  • magenta-background-color-default

  • pink-background-color-default

  • turquoise-background-color-default

  • brown-background-color-default

  • cinnamon-background-color-default

  • silver-background-color-default

Motivation and context

These updates to colors ensure we have a color stop that is 4.5:1 with white and 3:1 with gray-100. These color updates will fix accessibility issues for selected, accent variants in some components, like action button and tag.

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @larz0 larz0 requested a review from a team as a code owner August 12, 2024 20:32
    @mrcjhicks
    Copy link
    Collaborator

    TESTING spectrum2

    READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
    READING tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/

    WARNING - STUDIO INCLUDES DEPRECATED TOKEN: overlay-opacity/dark [31d5b502-6266-4309-8f8a-3892e6e158da]
    WARNING - STUDIO INCLUDES DEPRECATED TOKEN: overlay-opacity/light [26b9803c-577f-4a29-badd-dfc459e8b73e]

    SPECTRUM SYNC SUMMARY

    CHANGED VALUES: (48) accent-background-color-default/dark, accent-background-color-hover/dark, accent-background-color-down/dark, accent-background-color-key-focus/dark, informative-background-color-default/dark, informative-background-color-hover/dark, informative-background-color-down/dark, informative-background-color-key-focus/dark, positive-background-color-default/dark, positive-background-color-hover/dark, positive-background-color-down/dark, positive-background-color-key-focus/dark, negative-background-color-default/dark, negative-background-color-hover/dark, negative-background-color-down/dark, negative-background-color-key-focus/dark, blue-background-color-default/dark, green-background-color-default/dark, red-background-color-default/dark, brown-background-color-default/dark, cinnamon-background-color-default/dark, cyan-background-color-default/dark, fuchsia-background-color-default/dark, indigo-background-color-default/dark, magenta-background-color-default/dark, pink-background-color-default/dark, purple-background-color-default/dark, seafoam-background-color-default/dark, silver-background-color-default/dark, turquoise-background-color-default/dark, blue-800/dark, green-800/dark, orange-800/dark, red-800/dark, celery-800/dark, chartreuse-800/dark, cyan-800/dark, fuchsia-800/dark, indigo-800/dark, magenta-800/dark, purple-800/dark, seafoam-800/dark, yellow-800/dark, pink-800/dark, turquoise-800/dark, brown-800/dark, cinnamon-800/dark, silver-800/dark impacting 75 tokens
    

    TEST COMPLETE

    Copy link
    Contributor

    @lynnhao lynnhao left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Reviewed both the PR + the Figma branch. Both look good!

    Copy link
    Collaborator

    @karstens karstens left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM. Thank you!

    @karstens karstens merged commit 2ec619d into main Aug 19, 2024
    4 checks passed
    @karstens karstens deleted the larz0/SDS-13731-non-gray-800-colors-update branch August 19, 2024 17:13
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants