Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s2 foundations w/ corner radius #135

Merged
merged 13 commits into from
Aug 27, 2024

Conversation

mrcjhicks
Copy link
Collaborator

Description

Motivation and context

Related issue

Types of changes

  • Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
  • Minor (add a new token, changing a value, deprecating a token; non-breaking change which adds functionality)
  • Major (deleting a token, changing token value type, renaming a token by deprecating the old one; fix or feature that would cause existing functionality to change)
  • Checklist:

  • I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
  • I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)
  • @mrcjhicks mrcjhicks requested review from GarthDB and karstens May 31, 2024 18:57
    @GarthDB
    Copy link
    Member

    GarthDB commented May 31, 2024

    @mrcjhicks would we get a diff of any kind? or not, because it's a new data set? I guess it would just compare against the data that is already there, so no change.

    @mrcjhicks mrcjhicks marked this pull request as ready for review August 27, 2024 18:09
    @mrcjhicks mrcjhicks requested a review from a team as a code owner August 27, 2024 18:09
    @mrcjhicks mrcjhicks merged commit 5321e12 into cable/foundations Aug 27, 2024
    8 checks passed
    @mrcjhicks mrcjhicks deleted the cable/foundations-updates branch August 27, 2024 18:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants