fix(TagGroup): ensure Tags with and without icons are aligned vertically #7608
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
previously approved these changes
Jan 14, 2025
dannify
reviewed
Jan 14, 2025
| @@ -122,6 +122,20 @@ export const WithIcons: TagGroupStory = { | |||
| ) | |||
| }; | |||
|
|
|||
| export const WithSomeIcons: TagGroupStory = { | |||
There was a problem hiding this comment.
instead of a new one, can you change an existing story and just remove/add an avatar? That way we can also check chromatic.
snowystinger
approved these changes
Jan 14, 2025
devongovett
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you tried to use Tags with icons and without icons in the same TagGroup, they would not be vertically aligned. This seems to be a valid use case within Spectrum guidelines, so we want to ensure they can be used together without being misaligned.
✅ Pull Request Checklist:
📝 Test Instructions:
Check new story and chromatic.
🧢 Your Project: