Fix prop table in docs

[yihuiliao]

Currently not all our prop tables are loading properly, see https://react-spectrum.adobe.com/react-aria/Table.html#column

Broke in update react types pr so this PR reverts some of the changes there. Seems like it works fine if we just import {JSX} from 'react' and then change our definitions from React.JSX.Element to JSX.Element.

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check docs to make sure the prop tables are getting loaded properly.

🧢 Your Project:

[rspbot]

Build successful! 🎉

• View the storybook
• View the storybook-17
• View the storybook-16
• View the documentation

[LFDanLu]

Just out curiosity, did you find out when this broke in the prod docs? Also kinda weird that https://react-spectrum.adobe.com/react-spectrum/dnd.html#props has a reference to React.JSX.Element but it seems to work just fine.

[snowystinger]

https://react-spectrum.adobe.com/react-spectrum/dnd.html#props

@LFDanLu
It's not an issue inside a prop, it's an issue at the top level of the component Return type. However, changing it everywhere just simplifies things.

[yihuiliao]

Just out curiosity, did you find out when this broke in the prod docs?

@LFDanLu
i mentioned it above but it broke in this pr: #5237. so it's been about a month since it went out last release. seems like no one's reported it though

[rspbot]

Build successful! 🎉

• View the storybook
• View the storybook-17
• View the storybook-16
• View the documentation

[rspbot]

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@react-aria/dnd

DragPreviewProps

 DragPreviewProps {
-  children: (Array<DragItem>) => React.JSX.Element
+  children: (Array<DragItem>) => JSX.Element
 }

useClipboard

 DragPreview {
-  children: (Array<DragItem>) => React.JSX.Element
+  children: (Array<DragItem>) => JSX.Element
 }

---

@react-spectrum/dnd

DragAndDropOptions

 DragAndDropOptions {
   getItems?: (Set<Key>) => Array<DragItem> = () => []
-  renderPreview?: (Set<Key>, Key) => React.JSX.Element
+  renderPreview?: (Set<Key>, Key) => JSX.Element
 }

it changed:

• useDragAndDrop

DragAndDropHooks

 DragAndDropHooks {
   dragAndDropHooks: (DragHooks & DropHooks & {
     isVirtualDragging?: () => boolean
-  renderPreview?: (Set<Key>, Key) => React.JSX.Element
+  renderPreview?: (Set<Key>, Key) => JSX.Element
 })
 }

it changed:

• useDragAndDrop

---

@react-spectrum/list

ListView

 ListView<T extends {}> {
   density?: 'compact' | 'regular' | 'spacious' = 'regular'
   dragAndDropHooks?: DragAndDropHooks['dragAndDropHooks']
   isQuiet?: boolean
   loadingState?: LoadingState
   onAction?: (Key) => void
   overflowMode?: 'truncate' | 'wrap' = 'truncate'
-  renderEmptyState?: () => React.JSX.Element
+  renderEmptyState?: () => JSX.Element
 }

SpectrumListViewProps

 SpectrumListViewProps<T> {
   density?: 'compact' | 'regular' | 'spacious' = 'regular'
   dragAndDropHooks?: DragAndDropHooks['dragAndDropHooks']
   isQuiet?: boolean
   loadingState?: LoadingState
   onAction?: (Key) => void
   overflowMode?: 'truncate' | 'wrap' = 'truncate'
-  renderEmptyState?: () => React.JSX.Element
+  renderEmptyState?: () => JSX.Element
 }

---

@react-spectrum/table

Column

 TableView<T extends {}> {
   density?: 'compact' | 'regular' | 'spacious' = 'regular'
   dragAndDropHooks?: DragAndDropHooks['dragAndDropHooks']
   isQuiet?: boolean
   onAction?: (Key) => void
   onResize?: (Map<Key, ColumnSize>) => void
   onResizeEnd?: (Map<Key, ColumnSize>) => void
   onResizeStart?: (Map<Key, ColumnSize>) => void
   overflowMode?: 'wrap' | 'truncate' = 'truncate'
-  renderEmptyState?: () => React.JSX.Element
+  renderEmptyState?: () => JSX.Element
 }

CellProps

 SpectrumTableProps<T> {
   density?: 'compact' | 'regular' | 'spacious' = 'regular'
   dragAndDropHooks?: DragAndDropHooks['dragAndDropHooks']
   isQuiet?: boolean
   onAction?: (Key) => void
   onResize?: (Map<Key, ColumnSize>) => void
   onResizeEnd?: (Map<Key, ColumnSize>) => void
   onResizeStart?: (Map<Key, ColumnSize>) => void
   overflowMode?: 'wrap' | 'truncate' = 'truncate'
-  renderEmptyState?: () => React.JSX.Element
+  renderEmptyState?: () => JSX.Element
 }

---

@react-spectrum/tag

TagGroup

 TagGroup<T extends {}> {
   actionLabel?: string
   maxRows?: number
   onAction?: () => void
-  renderEmptyState?: () => React.JSX.Element
+  renderEmptyState?: () => JSX.Element
 }

SpectrumTagGroupProps

 SpectrumTagGroupProps<T> {
   actionLabel?: string
   maxRows?: number
   onAction?: () => void
-  renderEmptyState?: () => React.JSX.Element
+  renderEmptyState?: () => JSX.Element
 }

---