Skip to content

Commit

Permalink
Update pylint config and fix errors
Browse files Browse the repository at this point in the history
  • Loading branch information
saville committed Dec 14, 2023
1 parent 8577f2f commit 16018e7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 83 deletions.
85 changes: 3 additions & 82 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -65,86 +65,7 @@ confidence=
# --enable=similarities". If you want to run only the classes checker, but have
# no Warning level messages displayed, use "--disable=all --enable=classes
# --disable=W".
disable=print-statement,
parameter-unpacking,
unpacking-in-except,
old-raise-syntax,
backtick,
long-suffix,
old-ne-operator,
old-octal-literal,
import-star-module-level,
non-ascii-bytes-literal,
raw-checker-failed,
bad-inline-option,
locally-disabled,
file-ignored,
suppressed-message,
useless-suppression,
deprecated-pragma,
use-symbolic-message-instead,
apply-builtin,
basestring-builtin,
buffer-builtin,
cmp-builtin,
coerce-builtin,
execfile-builtin,
file-builtin,
long-builtin,
raw_input-builtin,
reduce-builtin,
standarderror-builtin,
unicode-builtin,
xrange-builtin,
coerce-method,
delslice-method,
getslice-method,
setslice-method,
no-absolute-import,
old-division,
dict-iter-method,
dict-view-method,
next-method-called,
metaclass-assignment,
indexing-exception,
raising-string,
reload-builtin,
oct-method,
hex-method,
nonzero-method,
cmp-method,
input-builtin,
round-builtin,
intern-builtin,
unichr-builtin,
map-builtin-not-iterating,
zip-builtin-not-iterating,
range-builtin-not-iterating,
filter-builtin-not-iterating,
using-cmp-argument,
eq-without-hash,
div-method,
idiv-method,
rdiv-method,
exception-message-attribute,
invalid-str-codec,
sys-max-int,
bad-python3-import,
deprecated-string-function,
deprecated-str-translate-call,
deprecated-itertools-function,
deprecated-types-field,
next-method-defined,
dict-items-not-iterating,
dict-keys-not-iterating,
dict-values-not-iterating,
deprecated-operator-function,
deprecated-urllib-function,
xreadlines-attribute,
deprecated-sys-function,
exception-escape,
comprehension-escape,
logging-fstring-interpolation,
disable=logging-fstring-interpolation,
missing-module-docstring,
missing-class-docstring,
missing-function-docstring,
Expand Down Expand Up @@ -594,5 +515,5 @@ min-public-methods=2

# Exceptions that will emit a warning when being caught. Defaults to
# "BaseException, Exception".
overgeneral-exceptions=BaseException,
Exception
overgeneral-exceptions=builtins.BaseException,
builtins.Exception
2 changes: 1 addition & 1 deletion pydc_control/docker_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def is_port_open(port):

def _is_path_responding(port: int, path: str) -> bool:
with contextlib.suppress(Exception):
return requests.get(f'http://localhost:{port}{path}').status_code == 200
return requests.get(f'http://localhost:{port}{path}', timeout=30).status_code == 200


def check_port(container_name: str, port: int, path: str) -> None:
Expand Down
1 change: 1 addition & 0 deletions pydc_control/test/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def _run_control_commands(args: List[str], working_dir: Optional[str] = None) ->
os.chdir(working_dir)
exit_code = pydc_control.run(SAMPLE_CONTROL_BASE_DIR, args=args)
if exit_code:
# pylint: disable=broad-exception-raised
raise Exception(f'Could not startup sample project due to exit code: {exit_code}')
if working_dir:
os.chdir(original_working_dir)
Expand Down

0 comments on commit 16018e7

Please sign in to comment.