Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Parse params parameter to get request parameters #45

Merged
merged 1 commit into from
Sep 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/defaults/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* governing permissions and limitations under the License.
*/
const winston = require('winston');
const querystring = require('querystring');
const Pipeline = require('../pipeline.js');

/**
Expand Down Expand Up @@ -44,8 +45,17 @@ const pre = cont => cont;
* @returns {Object} The original req object that is equivalent to an Express request object,
* including a headers, method, and params field
*/
function adaptOWRequest(payload, { logger, request: { params: { req = '{}' } = {} } = {} }) {
function adaptOWRequest(payload, { logger, request: { headers, method, params: { req = '{}', params = '' } = {} } = {} }) {
try {
if (params !== '') {
return {
request: {
params: querystring.parse(params),
headers,
method,
},
};
}
return {
request: JSON.parse(req),
};
Expand Down
15 changes: 15 additions & 0 deletions test/testDefault.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,21 @@ describe('Testing Default Pipeline', () => {
});
});

it('adaptOWRequest needs to parse params parameter', () => {
const testObject = {
foo: 'foo',
bar: 'bar',
};
const out = adaptOWRequest({}, { request: { params: { params: 'foo=foo&bar=bar' } } });
assert.ok(out.request, 'missing request object');
assert.deepEqual(testObject, out.request.params, 'request object does not match incoming req');
});

it('adaptOWRequest acts reasonably on wrong params parameter', () => {
const out = adaptOWRequest({}, { request: { params: { params: 'this is not url encoded' } } });
assert.ok(out.request, 'missing request object');
});

it('adaptOWRequest needs to parse req parameter', () => {
const testObject = {
url: 'url',
Expand Down