Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

use jsdom throughout the pipeline and use jsdom supporting htl engine #337

Closed
tripodsan opened this issue May 22, 2019 · 3 comments
Closed

use jsdom throughout the pipeline and use jsdom supporting htl engine #337

tripodsan opened this issue May 22, 2019 · 3 comments
Assignees
@tripodsan
Labels
released

Comments

@tripodsan
Copy link
Contributor

once the htl engine supports direct jsdom injection (see adobe/htlengine#62), it should be use in the pipeline.
@tripodsan tripodsan self-assigned this May 22, 2019
@rofe
Copy link
Contributor

rofe commented May 25, 2019

Once that is the case, can we resurrect adobe/htlengine#52? 😬

@tripodsan
Copy link
Contributor Author

Once that is the case, can we resurrect adobe/htlengine#52? 😬

yes. we could parse the injected HTML context with JSDOM and then use the dom-purifier on it. but only if JSDOM is enabled - so we need to keep the other sanitizer as well.

This was referenced May 29, 2019
Merged
Closed
Merged
@tripodsan tripodsan mentioned this issue Jun 6, 2019
Closed
adobe-bot pushed a commit that referenced this issue Jun 6, 2019
@semantic-release-bot
chore(release): 2.4.0 [skip ci]
17dd73c 
# [2.4.0](v2.3.0...v2.4.0) (2019-06-06)

### Features

* **pipe:** use jsdom everywhere ([479cc8a](479cc8a)), closes [#337](#337) [#336](#336)
@adobe-bot
Copy link

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jun 6, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tripodsan tripodsan

Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tripodsan @rofe @adobe-bot