-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: get rid of circleci and node v20 upgrade #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have new a combined file for build and release:
https://github.com/adobe/franklin-library/blob/4bd14ceb9fb48e32b35bc5a203aaf69b03a61a58/.github/workflows/main.yaml
Humm... what if I prefer having 2 separate files ? This is so much easier to read, especially when each script grow... (not the case here, I agree). Also, on branches, I find it better to run only on |
Ok, I have merged the 2 workflows in a single file. I have tried to optimise the code but you cannot get rid of the |
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.