Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of circleci and node v20 upgrade #291

Merged
merged 7 commits into from
Jan 18, 2024
Merged

chore: get rid of circleci and node v20 upgrade #291

merged 7 commits into from
Jan 18, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Jan 18, 2024

No description provided.

@kptdobe kptdobe requested a review from tripodsan January 18, 2024 07:31
@kptdobe kptdobe changed the title chore: get rid of circle ci and node v20 chore: get rid of circleci and node v20 upgrade Jan 18, 2024
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kptdobe
Copy link
Contributor Author

kptdobe commented Jan 18, 2024

we have new a combined file for build and release: https://github.com/adobe/franklin-library/blob/4bd14ceb9fb48e32b35bc5a203aaf69b03a61a58/.github/workflows/main.yaml

Humm... what if I prefer having 2 separate files ? This is so much easier to read, especially when each script grow... (not the case here, I agree).

Also, on branches, I find it better to run only on pull_request (not on push) to save some executions.

@kptdobe
Copy link
Contributor Author

kptdobe commented Jan 18, 2024

Ok, I have merged the 2 workflows in a single file. I have tried to optimise the code but you cannot get rid of the actions/checkout@v4, actions/setup-node@v4 and npm ci steps.

@kptdobe kptdobe merged commit 803d3b0 into main Jan 18, 2024
3 checks passed
@kptdobe kptdobe deleted the ci-update branch January 18, 2024 10:28
@adobe-bot
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants