feat: major redesign - get rid of JSDOM #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 95.76% 95.68% -0.09%
==========================================
Files 15 15
Lines 1607 1575 -32
==========================================
- Hits 1539 1507 -32
Misses 68 68
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
catalan-adobe
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Kudos for this refactoring! 👍
Other big improvements I see getting rid of JSDOM:
- Debugging import scripts will be so easier not having to deal with JSDOM!
- Access to all CSS values in the transform functions!
I tested helix-importer build + tests and also basic manual testing in helix-importer-ui with recent import script I've been working on.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
# [3.0.0](v2.9.41...v3.0.0) (2023-11-13) ### Features * get rid of JSDOM ([#260](#260)) ([2530363](2530363)) ### BREAKING CHANGES * removing JSDOM
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reduce the module size, I have been working on a major re-design, which includes:
This should not break backward compatibility in the browser usage case (I tested it in the helix-importer-ui context). But when used in Node.JS, you will need to provide a
createDocumentFromStringmethod.Will flag the release as major.