Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Make sure JS Code Hints list exact matches first #5716

Closed
wants to merge 2 commits into from
Closed

Make sure JS Code Hints list exact matches first #5716

wants to merge 2 commits into from

Conversation

lkcampbell
Copy link
Contributor

This PR fixes issue #3971.

@ghost ghost assigned dangoor Oct 26, 2013
@lkcampbell
Copy link
Contributor Author

@dangoor, I'm not 100% sure this solution is the correct approach. Right now I am addressing the problem at the JavaScript Code Hints level. Should it be be approached at the higher level of the String Match code?

For example, here's a QuickOpen scenario. If I create files xxx.txt and XXY.txt, then enter "xx" or "XX" as my search string, I always get "xxx.txt" as my highest match and "XXY.txt" as my second choice. Is this by design? Should all String Match results be case sensitive or should it be a case by case basis?

@dangoor
Copy link
Contributor

dangoor commented Oct 27, 2013

Ideally, StringMatch would have a preference for characters that match the case exactly. I think there may be an issue open on that specifically.

@lkcampbell
Copy link
Contributor Author

In that case, disregard this PR. I want to address this in a broader scope. I will either change this or close it and submit another PR.

@lkcampbell
Copy link
Contributor Author

@dangoor, I'm closing this PR, going to try out a different approach this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants