This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Change SpecRunner to run more than one suite, fix issues in tests #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk. Fix bug in NativeFileSystem where an empty dir will list the entire disk contents.
| @@ -156,7 +156,8 @@ define(function (require, exports, module) { | |||
|
|
|||
| // Prevent adding doc to working set | |||
| docToShim._handleEditorChange = function (event, editor, changeList) { | |||
| this.isDirty = true; | |||
| var wasDirty = this.isDirty; | |||
There was a problem hiding this comment.
Seems like wasDirty is unused?
There was a problem hiding this comment.
Oops. Copy paste error. Thanks.
| @@ -99,7 +99,7 @@ define(function LiveDevelopment(require, exports, module) { | |||
| "edit" : require("LiveDevelopment/Agents/EditAgent") | |||
| }; | |||
|
|
|||
| var launcherUrl = window.location.href.replace(/\/index.html.*/, "") + "/LiveDevelopment/launch.html"; | |||
| var launcherUrl = window.location.href.replace(/\/(src\/index.html|test\/SpecRunner.html).*/, "") + "/src/LiveDevelopment/launch.html"; | |||
There was a problem hiding this comment.
I'm not very familiar with the LiveDevelopment code, but I'm not clear about the addition of "src/" for the cases that are not the SpecRunner. This is used in the real builds of Brackets, right? (which I presume don't have src directories?)
There was a problem hiding this comment.
Grr...you're right. I'll fix, thanks.
…tion timeout in unit test.
…ets into jasonsanjose/fix-live-dev-ci
|
Looks good to me. The new category handling (and multiple suite support) in the specrunner is much nicer than the old code there. |
dangoor
added a commit
that referenced
this pull request
Apr 5, 2013
Change SpecRunner to run more than one suite, fix issues in tests
peterflynn
added a commit
that referenced
this pull request
Apr 5, 2013
(extensions/default) extensions show up in the spec running UI.
peterflynn
added a commit
that referenced
this pull request
Apr 9, 2013
* origin/master: (37 commits) Fix unit tests to account for 2feef29 update unit tests now that shell mode is a default language Fixes after second review remove extra StringUtils use emdash on mac only add licenses Fixes after first review Fix after review A bit cleanup revert change to unit test fixture again revert change to unit test fixture It now passes editor as a parameter using run and all the tests run in one window Fixes after second review Collect style tags the same way as we collect script tags. ie. collect everything up to the end tag in one step. Fixes after review Correct fix for gutter padding issue in #3211 Fix running dev & user extension unit tests. After pull #3334 only core (extensions/default) extensions show up in the spec running UI. keep html title for in-browser. update unit tests. Fixed replacement when currently in Entity Minor text fixes ... Conflicts: src/document/DocumentCommandHandlers.js src/extensions/default/RecentProjects/main.js test/spec/DocumentCommandHandlers-test.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, instead of running "all", the Jenkins machines will run
grunt test-integration --suite="unit,extension"only.I made some attempts to fix issues in the integration suite, but I wasn't able to fix all issues, particularly intermittent NodeConnection and LiveDevelopment issues that seem to only reproduce on the build machines.
A short summary:
readEntrieson an empty path would read the entire diskThere also appears to be a memory leak when running unit tests that I did not have time to pin down. I'd like to get at least these changes in ASAP in order to get Jenkins running again.