This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Set src/nls/zh-cn/strings.js to binary #3164
Closed
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2013
|
@DennisKehrig -- Are you on WinXP? It seems that no one else having any issue with this file after Kevin fixed the line endings in this file. Have you tried again after Kevin landed his changes? I don't have any issue on my Win 7 and Mac 10.8.2. So we may not need this one even if this is specific to WinXP, but I doubt it though. We've already had Japanese translation and this is just another utf-8 document with CJK characters. |
|
It seems I just barely missed Kevin's changes - bad timing. I'll close it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not entirely sure this is the right way to do it.
Whenever I run
git checkout masterunder Windows, and thengit checkout <some branch>, git thinks I have changedsrc/nls/zh-cn/strings.js. By setting it to binary via.gitattributes, I no longer have this problem.