Made Language.addFileExtension public #3051
Conversation
…, made DocumentManager update document's languages as necessary
|
Rebased |
|
Reviewing |
| @@ -403,6 +426,7 @@ define(function (require, exports, module) { | |||
| _validateNonEmptyString(prefix, "prefix"); | |||
|
|
|||
| this._lineCommentSyntax = { prefix: prefix }; | |||
| this._wasModified(); | |||
There was a problem hiding this comment.
Is this useful to notify when the comment markup changes? I appreciate the completeness but I don't think there should be anything actionable unless for some reason a client cached the comment markup values.
There was a problem hiding this comment.
It is for completion... I have a hard time coming up with use cases, too. But it's also a non-issue since the languageModified event is only triggered for languages that are already registered, so this would only happen for languages that get different comment settings after having been defined.
Would you prefer to have it removed?
There was a problem hiding this comment.
Nope, it's fine as-is. Thanks.
|
Initial review complete |
|
Thanks, @jasonsanjose! |
Conflicts: src/language/LanguageManager.js
|
Merging. |
Made Language.addFileExtension public
Fixes #2966