Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Closed file left half-open if next working set entry no longer exists #1544

Closed
peterflynn opened this issue Sep 1, 2012 · 3 comments
Closed
Assignees

Comments

@peterflynn
Copy link
Member

  1. Open three files in the working set: A, B, and C
  2. Make sure file C is selected
  3. Close Brackets
  4. Delete file B
  5. Reopen Brackets
  6. Close file C

Result: after dismissing the error dialog about being unable to open file B, you're left with nothing selected in the left-hand pane, and file C still open in an editor but no longer listed in the working set.

Although it looks pretty broken/sketchy, I think the underlying Document stuff is still in an ok state -- if you type in the "orphaned" editor, file C is re-added to the working set and saving changes works.

@peterflynn
Copy link
Member Author

I think variations of this bug were always possible in rare edge cases, but pull #1197 made it much easier to hit (via the above steps). It looks ugly enough that I think we should consider fixing for Sprint 14...

@ghost ghost assigned redmunds Sep 1, 2012
peterflynn added a commit that referenced this issue Sep 6, 2012
Fix bugs #1543 and #1544: working set files are not guaranteed to be openable, so check for failure; defer assertion until it's (supposed to be) guaranteed to be valid
@redmunds
Copy link
Contributor

redmunds commented Sep 6, 2012

FBNC back to @peterflynn

@peterflynn
Copy link
Member Author

Confirmed fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants