Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Commit

Permalink
Merge pull request #2325 from adobe/jasonsanjose/issue-2130
Browse files Browse the repository at this point in the history
Use scrollTop instead of scrollIntoView for #2130
  • Loading branch information
redmunds committed Dec 11, 2012
2 parents 211f899 + c39ff01 commit 7ba8722
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions src/utils/ViewUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,18 @@ define(function (require, exports, module) {
elementOffset = $element.offset();

// scroll minimum amount
if (elementOffset.top + $element.height() >= (viewOffset.top + $view.height())) {
var delta = (elementOffset.top + $element.height()) - (viewOffset.top + $view.height());

if (delta > 0) {
// below viewport
element.scrollIntoView(false);
} else if (elementOffset.top <= viewOffset.top) {
// above viewport
element.scrollIntoView(true);
$view.scrollTop($view.scrollTop() + delta);
} else {
delta = viewOffset.top - elementOffset.top;

if (delta > 0) {
// above viewport
$view.scrollTop($view.scrollTop() - delta);
}
}

if (scrollHorizontal) {
Expand Down

0 comments on commit 7ba8722

Please sign in to comment.