tests for main.js that is not in the commonPrefix (to guarantee that …

…we have a main

at the top level of the extension)

src/extensibility/node/ExtensionManagerDomain.js

@@ -104,7 +104,7 @@ function _cmdValidate(path, callback) {
         }
         var callbackCalled = false;
         var metadata;
-        var foundMain = false;
+        var foundMainIn = null;
         var errors = [];
         var commonPrefix = null;
 
@@ -183,7 +183,7 @@ function _cmdValidate(path, callback) {
                             }
                         });
                 } else if (fileName === "main.js") {
-                    foundMain = true;
+                    foundMainIn = commonPrefix;
                 }
             })
             .on("end", function () {
@@ -195,7 +195,7 @@ function _cmdValidate(path, callback) {
                     return;
                 }
 
-                if (!foundMain) {
+                if (foundMainIn === null || foundMainIn !== commonPrefix) {
                     errors.push([Errors.MISSING_MAIN, path]);
                 }
 

src/extensibility/node/spec/Validation.spec.js

@@ -49,6 +49,7 @@ var basicValidExtension = path.join(testFilesDirectory, "basic-valid-extension.z
     oneLevelDown        = path.join(testFilesDirectory, "one-level-extension-master.zip"),
     bogusTopDir         = path.join(testFilesDirectory, "bogus-top-dir.zip"),
     badname             = path.join(testFilesDirectory, "badname.zip"),
+    mainInDirectory     = path.join(testFilesDirectory, "main-in-directory.zip"),
     invalidVersion      = path.join(testFilesDirectory, "invalid-version.zip");
 
 describe("Package Validation", function () {
@@ -168,4 +169,14 @@ describe("Package Validation", function () {
             done();
         });
     });
+
+    it("should complain about files that don't have main in the top dir", function (done) {
+        ExtensionsDomain._cmdValidate(mainInDirectory, function (err, result) {
+            expect(err).toBeNull();
+            var errors = result.errors;
+            expect(errors.length).toEqual(1);
+            expect(errors[0][0]).toEqual("MISSING_MAIN");
+            done();
+        });
+    });
 });