This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
moving command line error to infobar and fixing windows port range issues #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narayani28
reviewed
Nov 21, 2019
|
@shubhsnov renamed the error string variable, as suggested. |
g-217
pushed a commit
to g-217/brackets-shell
that referenced
this pull request
Nov 21, 2019
…r-to-infobar2 moving command line error to infobar and fixing windows port range issues
This was referenced Nov 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows was allowing Brackets to open a remote debugging port on any port in the range [1,65534], which was troubling.
So, have started setting
settings.remote_debugging_port=65535in case of ports outside the interval [1024,65534].Which stops Brackets from opening a reserved port and this stops error thrown in
bind()on Linux and Mac.