Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

AutoUpdate Feature Health Data Logging Changes #639

Merged
merged 3 commits into from
Apr 23, 2018
Merged

AutoUpdate Feature Health Data Logging Changes #639

merged 3 commits into from
Apr 23, 2018

Conversation

niteskum
Copy link
Contributor

This PR includes changes for Auto Update Feature Health Data Logging Changes

@niteskum
Copy link
Contributor Author

@mbhavi @navch @nethip to review changes

@navch
Copy link
Contributor

navch commented Apr 21, 2018

Can you please add some description, why we doing this?

@niteskum
Copy link
Contributor Author

This changes in All Auto Update Feature Error Log Statement
Error Log should have "ERROR:" string. so that Error Statement can be tracked using string "ERROR:".
And Error Log Statement should end with an unique error code. and we will maintain a wiki page where this Unique Codes will be mapped with their corresponding error message.
with this we can parse the Log and get the Error Code. and we will send only Error code to Analytics Server not the Complete Error Message to minimize the amount of data to be sent over the Server and the storage in Database.

else
printInfo "Opened Brackets."
fi
fiS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

@@ -38,37 +38,37 @@ function printError(){
function verifySetup(){
if [ "$APP_DIR" == "$EMPTY_STRING" ]
then
printError "Brackets app dir is missing"
printError "Brackets app dir is missing: INS_O1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need "Error" word in these strings?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ERROR:" String will be added by printError Function so we don't need to add explicitly.

@nethip nethip merged commit d5c923f into adobe:master Apr 23, 2018
@nethip
Copy link
Contributor

nethip commented Apr 23, 2018

Thanks @niteskum for the changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants