-
Notifications
You must be signed in to change notification settings - Fork 613
AutoUpdate Feature Health Data Logging Changes #639
AutoUpdate Feature Health Data Logging Changes #639
Conversation
Can you please add some description, why we doing this? |
This changes in All Auto Update Feature Error Log Statement |
installer/mac/update.sh
Outdated
else | ||
printInfo "Opened Brackets." | ||
fi | ||
fiS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
@@ -38,37 +38,37 @@ function printError(){ | |||
function verifySetup(){ | |||
if [ "$APP_DIR" == "$EMPTY_STRING" ] | |||
then | |||
printError "Brackets app dir is missing" | |||
printError "Brackets app dir is missing: INS_O1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need "Error" word in these strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ERROR:" String will be added by printError Function so we don't need to add explicitly.
Thanks @niteskum for the changes. |
This PR includes changes for Auto Update Feature Health Data Logging Changes